Viewing a single comment thread. View all comments

twovests wrote (edited )

Reply to comment by emma in Is it just me or is the thumbnail not getting loaded when I post a link by nitori

Uh oh, docker ps does indeed show our postmill-docker-example-php-worker-1 is not alive.

It seems it died trying to download this 5220x4016 png from connections.swellgarfo.com,

01:34:41 INFO      [http_client] Response: "200 https://connections.swellgarfo.com/facebookimage.png" 0.050993 seconds ["http_code" => 200,"url" => "https://connections.swellgarfo.com/facebookimage.png","total_time" => 0.050993]
PHP Fatal error:  Allowed memory size of 201326592 bytes exhausted (tried to allocate 83854080 bytes) in /app/vendor/symfony/validator/Constraints/ImageValidator.php on line 229
01:34:41 CRITICAL  [php] Fatal Error: Allowed memory size of 201326592 bytes exhausted (tried to allocate 83854080 bytes) ["exception" => Symfony\Component\ErrorHandler\Error\OutOfMemoryError { …}]

In ImageValidator.php line 229:

  [Symfony\Component\ErrorHandler\Error\OutOfMemoryError]
  Error: Allowed memory size of 201326592 bytes exhausted (tried to allocate
  83854080 bytes)


Exception trace:
  at /app/vendor/symfony/validator/Constraints/ImageValidator.php:229

That image clocks in at about 60MiB, and it tries to allocate 83854080 (about 80MiB), which under a constraint of 201326592 (exactly 192 MiB), which makes me think there's something (PHP interpreter/vm? Malloc call?) with a constant 192 MiB allocated.

I see memory_limit=192m under docker/php/zz-postmill.ini in the Postmill original repo.

Whatever the "right" solution is, I think I can

  1. Reboot the server for now, to get the PHP worker up and running

  2. Increase that value, since our server has about 2GiB of RAM to work with.

Re: Increasing that value, I need to look into the best way to do that. I love Docker but the indirection does leave me mulling over "what is the best way to make this simple change"? (Is that .ini a path which Docker Compose can override? Is this something to finally make a Postmill downstream for?)

TLDR: The short-term solution is a reboot, the medium-term solution is increasing memory allocated; rebooting now!

EDIT: After rebooting, it seems the php worker still does not launch. I forgot how the server launches Docker so I'm re-exploring that now

2

flabberghaster wrote

Uh oh, docker ps does indeed show our postmill-docker-example-php-worker-1 is not alive

I call it dorker btw.

4

twovests wrote

for what it's worth, i haven't fixed it yet, but i am now bogged down in "200 pages of severance documents"

2

emma wrote

make a zzzzzzzz-jstpst.ini with just the memory limit setting and mount it in /usr/local/etc/php/conf.d, would be my suggestion

2

twovests wrote

this worked perfectly!!! thank you :D

for anyone who wants to copy this (or, future us), we added roughly this to the docker-compose yaml:


volumes:
 - ${PWD}/zzz-postmill.ini:/usr/local/etc/php/conf.d/zzz-postmill.ini

where zzz-postmill.ini had a higher memory. we had to put it in both of the php images

1

twovests wrote

Thank you! Just to confirm, this would go inside the PHP worker container, right? Or somewhere else

(I'd test directly but I'm on mobile right now, and the container being dead makes it tricky to sh into)

1

emma wrote

yep

2

twovests wrote

rad, ty! will try that

I just tried that in the other php container, in the hopes that they somehow share a config. Tried adding a new file and then again by editing the zz-postmill.ini directly. Rebooting each time because I am the worlds worst and most evil sysadmin.

The reason the site was down for a full few minutes was because I was hoping it might be possible to sh into the container if I did so before anyone made a call to the site, but it seems to try to thumbnail the image first thing it does.

I know I need to do the proper thing (set it up so that file is "mounted" from my host filesystem into the container) but it's just a Thing I Gotta Figure Out How To Do

1

twovests wrote

Sorry to Flabberghaster for forgetting all the details lol, but I re-discovered our postmill.service unit files. Nothing surprising.

It seems indeed the php worker does launch and try - but fails - to download that image

Not in a place rn to do this, but it seems like the thing to do would be to (1) make a Postmill downstream (2) Update the .ini to have a higher memory limit (3) Build new images from that

1